Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use cElementTree on Python 3 #502

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Don't use cElementTree on Python 3 #502

merged 1 commit into from
Jun 17, 2020

Conversation

gsnedders
Copy link
Member

This just directly imports the first commit from pypa/pip#8278. Fixes #494. This doesn't fill me with joy, but I guess sometimes we do the perhaps silly thing for pip.

(@tiran this is just your commit, let me know if you have any objection to it landing here)

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020 •
edited
Loading

Codecov Report

Merging #502 into master will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          50       50           
  Lines        7036     7038    +2     
  Branches     1340     1341    +1     
=======================================
+ Hits         6407     6409    +2     
  Misses        475      475           
  Partials      154      154
Impacted Files Coverage Δ
html5lib/_utils.py 82.95% <66.66%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b08cc...e4ff95f. Read the comment docs.

jgraham
jgraham previously approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ but I agree with the preference for if not PY2 in this case, although I'm obviously hoping Python 4 isn't a real thing since it will just cause more needless breakage.

@gsnedders gsnedders mentioned this pull request Jun 16, 2020
Closed
@tiran @gsnedders
Don't use cElementTree on Python 3
e4ff95f 
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't
have cElementTree. I'd like to bring it back with a deprecation warning
to drop in 3.10.

See: python/cpython#19921
Signed-off-by: Christian Heimes <christian@python.org>
Signed-off-by: Sam Sneddon <me@gsnedders.com>
@gsnedders gsnedders force-pushed the conditional_etree branch from 3d62987 to e4ff95f Compare June 17, 2020 19:55
@gsnedders
Copy link
Member Author

r+ but I agree with the preference for if not PY2 in this case, although I'm obviously hoping Python 4 isn't a real thing since it will just cause more needless breakage.

Note that this has been discussed upstream at six on a number of occasions: see https://bitbucket.org/gutworth/six/issues/22/variable-sixpy3-is-time-bomb and benjaminp/six#297, as well as the python-dev thread at https://mail.python.org/archives/list/python-dev@python.org/thread/M5N3PZP4IUMKRZJKKJQA4IXK5VDX5MOP/ about 3.10 v. 4.

@gsnedders
Copy link
Member Author

I'm landing this as-is because if that's what a CPython core developer is doing that's good enough for me 🤷

@gsnedders gsnedders merged commit 7e52b16 into html5lib:master Jun 17, 2020
@gsnedders gsnedders deleted the conditional_etree branch June 17, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid cElementTree on Python 3
4 participants
@gsnedders @codecov-commenter @jgraham @tiran