Fail for unknown namespace. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a prefix is not in a registered namespace, instead of effectively falling back to a default set of caches, return a failure. This is meant to provide reasonable error messages when there are typos in the URL instead of making it look like there's an issue with the caches. Here's an example output from `stashcp`: ``` stashcp osdf://typo/staging/bbockelm/foo /dev/null ERROR[2023-06-03T10:58:53-05:00] Failure downloading osdf://typo/staging/bbockelm/foo: Attempt htcondor#1: OSDF namespace not known for path /typo/staging/bbockelm/foo (100ms since start) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a prefix is not in a registered namespace, instead of effectively falling back to a default set of caches, return a failure.
This is meant to provide reasonable error messages when there are typos in the URL instead of making it look like there's an issue with the caches.
Here's an example output from
stashcp: