Permit disabling use of http_proxy #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context of the HTCSS download plugin, it's not possible to remove the http_proxy environment variable. Add a second environment variable to disable things. Either of these are permitted: - OSG_DISABLE_HTTP_PRXY - OSDF_DISABLE_HTTP_PROXY If the HTTP proxy is disabled, then fallback is also disabled. Additionally, this permits it to accept OSDF_DISABLE_PROXY_FALLBACK as an alias to OSG_DISABLE_PROXY_FALLBACK.
|
Has this been tested? |
|
Yes - hand tested. Easiest when you just set http_proxy to an invalid hostname and then look at the debug output. |
|
Looks good. In the end, we will probably have to start using something like a configuration reader like Viper, but this will work for now. |
|
I don't understand why this isn't disabled by default. There's too many cases where squids will accidentally be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of the HTCSS download plugin, it's not possible to remove the http_proxy environment variable. Add a second environment variable to disable things. Either of these are permitted:
If the HTTP proxy is disabled, then fallback is also disabled.
Additionally, this permits it to accept OSDF_DISABLE_PROXY_FALLBACK as an alias to OSG_DISABLE_PROXY_FALLBACK.