Fix static buffer overrrun (issue #443) #445
Conversation
result[6] is a fixed array of size 6, but in the process of copying data into it, we clobber the last allocated byte. Simplify some of the code by not calling redundant functions.
|
@AdamMajer thanks for the PR... eyeballing the code it certainly seems to avoid an overrun... And the code feels cleaner, but wonder why I have yet to test #443... but it certainly looks like this addresses that... Will merge shortly, unless others see a problem... thanks... |
|
maybe it is redundant but search can get overwritten by a lookup table and I didn't check if that lookup table is always lower case. I only removed crazy things like strncpy 1 char. :) |
|
@AdamMajer well, it appear the table is in lowercase, but this protects against table changes... Have now had a chance to add Accordingly, have merged it, and bumped to version 5.3.9 (2016.08.04)... thanks... |
result[6] is a fixed array of size 6, but in the process
of copying data into it, we clobber the last allocated byte.
Simplify some of the code by not calling redundant functions.