Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scales with d3 v5 #270

Merged
merged 4 commits into from
Apr 12, 2018
Merged

Update scales with d3 v5 #270

merged 4 commits into from
Apr 12, 2018

Conversation

trainorpj
Copy link
Contributor

💥 Breaking Changes

  • Removed color scales, recommending that users look to d3-scale-chromatic, following d3's lead in release 5.0.0
  • The following files/tests/documentation are no longer part of vx/scale:
    • schemeCategory10
    • schemeCategory20
    • schemeCategory20b
    • schemeCategory20c

🚀 Enhancements

  • N/A

📝 Documentation

  • Added a section on color scales, which goes over how one would use d3-scale-chromatic with vx/scale
    • I tried out my code in a sandbox, if you'd like to see it 🙂

🐛 Bug Fix

🏠 Internal

  • 🎉

@hshoff hshoff added this to the v0.0.161 milestone Apr 12, 2018
@hshoff
Copy link
Member

hshoff commented Apr 12, 2018

LGTM thanks for this!

@hshoff hshoff merged commit d2aac5b into airbnb:master Apr 12, 2018
@williaster
Copy link
Collaborator

wohoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.161
Development

Successfully merging this pull request may close these issues.
3 participants
@trainorpj @hshoff @williaster