You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove d3.schemeCategory20* categorical color schemes. (See note below.)
.
.
D3 now includes new categorical color schemes from ColorBrewer, along with ColorBrewer’s excellent diverging, sequential single-hue and sequential multi-hue color schemes. The twenty-color schemes were removed because their grouped design often falsely implied non-existent relationships in the data: a shared hue can imply that the encoded data are part of a group (a super-category), while the relative lightness can falsely imply order.
Issues that come from this:
vx is not consistent with the latest release of d3
If someone wanted to learn more about d3-scales page, they'd be confused as to why vx says there are colors, but d3 says otherwise 😢
Images on the @vx/scales readme are broken
Proposed Solution:
Port d3-scale-chromatic to @vx/scales, and update the docs. This won't change the API, i.e.
// old wayimport{schemeCategory10}from'@vx/scale'// new way... it's the same :)import{schemeCategory10}from'@vx/scale'
Breaking Changes:
For better or for worse (seems like for better) schemeCategory20[b,c] won't work anymore
Thanks for reading 😄
Let me know if you'd like help on this. I'd be happy to submit a PR once this has @hshoff's blessing 🙏
The text was updated successfully, but these errors were encountered:
We should follow d3s lead here and remove the categorical color schemes from @vx/scale altogether. The reasoning makes sense to me:
The twenty-color schemes were removed because their grouped design often falsely implied non-existent relationships in the data: a shared hue can imply that the encoded data are part of a group (a super-category), while the relative lightness can falsely imply order.
Then we can point folks to d3-scale-chromatic and not have to worry about maintaining a wrapper around it.
@vx/scale was made with the plan of eventually making scales play nicer in react land by making them immutable (easier checking in shouldComponentUpdate()). Currently @vx/scale just provides the non-fluent api around d3-scale:
// d3scaleLiner().domain().range()// vxscaleLinear({ domain, range })
I was looking through @vx/scale, when I noticed that it's not up-to-date with d3 v5.0.0 (the most current version)
The release notes have these two announcements:
Issues that come from this:
Proposed Solution:
Port d3-scale-chromatic to @vx/scales, and update the docs. This won't change the API, i.e.
Breaking Changes:
For better or for worse (seems like for better)
schemeCategory20[b,c]
won't work anymoreThanks for reading 😄
Let me know if you'd like help on this. I'd be happy to submit a PR once this has @hshoff's blessing 🙏
The text was updated successfully, but these errors were encountered: