Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of episode on Particle package #64

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

eduardo-rodrigues
Copy link
Member

Instructions

Thanks for contributing! ❤️

Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution.

To ensure that someone gets notified, you can also click on "Request a review" and add
the suggested person.

Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact the HSF training convenors.

You may delete these instructions from your comment.

- HSF Training

Copy link

welcome bot commented Jan 10, 2024

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see
our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

@eduardo-rodrigues
Copy link
Member Author

This is a little update to avoid deprecated methods about to be removed and add 1-2 extra examples of functionality provided.

Copy link
Collaborator

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this is an essential update. In the latest version of Particle (0.23.1),

>>> import particle
>>> particle.Particle.from_string("Z0")
<stdin>:1: DeprecationWarning: This method is deprecated and will be removed from version 0.23.0. Use finditer or findall instead.
<Particle: name="Z0", pdgid=23, mass=91187.6 ± 2.1 MeV>

but

>>> import particle
>>> particle.Particle.from_name("Z0")
<Particle: name="Z0", pdgid=23, mass=91187.6 ± 2.1 MeV>

The additional examples of functionality are nice, too!

What's the policy on PR approvals, @klieret? Is one approval sufficient to merge?

@eduardo-rodrigues
Copy link
Member Author

This has been approved a while back and a no-brainer. Merging at this point :-).

@eduardo-rodrigues eduardo-rodrigues merged commit f5c8aa9 into main Feb 9, 2024
3 checks passed
@eduardo-rodrigues eduardo-rodrigues deleted the eduardo-particle-update branch February 9, 2024 14:59
Copy link

welcome bot commented Feb 9, 2024

Congrats on merging your first pull request 🎉! We greatly appreciate it.
You might be eligible to be added to the HSF Training Community page (see the instructions on the page for how to create a profile). If you already have created a profile previously, make sure you're also added to the current year. If this repository features a list of contributors at the bottom of the readme, you might also be eligible to add yourself there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants