Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use uproot5 link (do not rely on redirect) #61

Merged

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Dec 4, 2023

Fixes #56. I know it's not necessary, but I'm working through our long issue list (ofr all hsf-training) and fixing/closing where I can.

@wdconinc wdconinc requested a review from jpivarski December 4, 2023 15:53
@wdconinc wdconinc linked an issue Dec 4, 2023 that may be closed by this pull request
Copy link
Collaborator

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right; this is the up-to-date URL. The URL had to change for obvious reasons (the version is not 4.x anymore) and unfortunately, the unqualified URL goes to the latest Uproot 3.x code. (Changing that URL to point to the latest code would mix issue numbers.)

@wdconinc wdconinc merged commit e8a171c into main Dec 4, 2023
3 checks passed
@klieret klieret deleted the 56-tools-for-scaling-up-web-links-need-to-be-checked branch December 6, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tools for scaling up -> web links need to be checked
2 participants