Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken styling #6

Merged
merged 4 commits into from
Aug 18, 2020
Merged

fix: Broken styling #6

merged 4 commits into from
Aug 18, 2020

Conversation

henryiii
Copy link
Collaborator

Partial fix for #5 - disables styling if the structure is wrong.

@henryiii henryiii merged commit 69c1784 into gh-pages Aug 18, 2020
@henryiii henryiii deleted the henryiii/fixinc branch August 18, 2020 20:16
@klieret
Copy link
Member

klieret commented Aug 19, 2020

Cool!! Would you be interesting in pitching that back to https://github.com/carpentries/styles? This is also in our interest because we keep our hsf-styles (kind of) synced to theirs and pull from hsf-styles to all lesson repositories (including this one), so this would reduce the probability for merge conflicts in the future.

@henryiii
Copy link
Collaborator Author

Done, though I can actually revert the stylesheet change if need be, since the workaround I ended up using makes these "normal".

@henryiii
Copy link
Collaborator Author

Both fix and C/C++/CMake languages is upstream! Can the hsf-styles be synced?

@klieret
Copy link
Member

klieret commented Aug 19, 2020

Done! Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants