Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/styles #19

Merged
merged 70 commits into from
Apr 12, 2021
Merged

Chore/styles #19

merged 70 commits into from
Apr 12, 2021

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Dec 18, 2020

Updating styles.

@klieret This is the list of failures:

_extras/discuss.md:4:FIXME
_extras/guide.md:4:FIXME
./404.md:11: Unknown or missing blockquote type caution

The 404 page is directly from styles!, and so are discuss and guide. (though maybe I need to update those?).

I assume once this works, this is a better check than travis, so we can drop travis.

ErinBecker and others added 30 commits January 30, 2018 12:02
Bring in latest changes to styles repository
translate 'finish' to 'final
@klieret
Copy link
Member

klieret commented Jan 6, 2021

Hi @henryiii

Sorry, late to the party. Let me quickly address the 3 errors:

  • discuss.md and guide.md: These FIXMEs are there to remind the author of the lesson to add some content (can't be done in styles)
  • 404: Strange, that should work. .caution is registered in the css meanwhile. Perhaps the warning disappears when everything is merged? Looks like a mismatch of versions or 404.md and the assets...

@henryiii
Copy link
Collaborator Author

Looks like Boost has been removed: actions/runner-images#2667 :(

@henryiii henryiii force-pushed the chore/styles branch 2 times, most recently from 3a150d6 to 7c00e6b Compare April 12, 2021 16:45
@henryiii henryiii force-pushed the chore/styles branch 2 times, most recently from 21dafa3 to c63513f Compare April 12, 2021 18:23
@henryiii henryiii merged commit cd65e39 into gh-pages Apr 12, 2021
@henryiii henryiii deleted the chore/styles branch April 12, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.