RetroAchievements: Add function to view leaderboards #17629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
| Achievements::EnumerateLeaderboards([&](const Achievements::Leaderboard &leaderboard) { | ||
| leaderboards.push_back(leaderboard); | ||
| return true; | ||
| }); |
There was a problem hiding this comment.
nit: This happens a few times in this file, something I noticed VS 2022 is doing that I don't like. If you also don't like it: I found that disabling "Indent braces of lambdas used as parameters" stops it from happening (although I might actually want that, just certainly not when the code and braces are indented the same which is the common-case result.)
-[Unknown]
There was a problem hiding this comment.
Oh, didn't realize there was an option for that! I will enable it.
Though, looks like all the instances of the problem are gone now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, you can now view leaderboards directly from within PPSSPP.
Player avatars are not yet loaded, otherwise fully functional.