Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting: Slow framebuf effects #15948

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Sep 3, 2022

We want to have as few settings as possible that break graphics, and they better provide a major speedup if they do.

This one doesn't meet the cut, especially now that the really slow parts have been moved behind the "Enable block transfer" setting.

If some games get too slow on some device with this, I'm willing to look into more specific workarounds. But blanket settings like this that generally do not provide much of a speed boost, well, they just cause too much trouble.

@hrydgard hrydgard added the Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. label Sep 3, 2022
@hrydgard hrydgard added this to the v1.14.0 milestone Sep 3, 2022
@Panderner
Copy link
Contributor

The bad news is some games that needs to turn on Disable slower effects fix issues like Indiana Jones and Call of Duty for older Mali GPUs (#11598 and #11573)

@hrydgard
Copy link
Owner Author

hrydgard commented Sep 3, 2022

True, but I'd rather go investigate and fix the root cause of those problems instead, removing workarounds like this will kinda force me to :)

If games break temporarily on old hardware, that will have to be OK as long as I fix it for the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants