Windows: Stop ignoring all deprecated warnings #14177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is a better way, nice one. UWP is unhappy - I think you'll need to do the same in those vcprojs. Unfortunately I wasn't able to find a way to get UWP builds from the same project files to work, which is indeed really silly. |
unknownbrackets
force-pushed
the
warnings
branch
from
bf55228
to
c4010bf
Compare
|
I did change UWP but didn't try to build it, must've missed a file. Let's see if this works with UI_UWP changed too. Also seemed to error on deprecated instead of warning... -[Unknown] |
|
Oh, sorry, didn't look carefully enough at that diff. Yeah let's hope that was it... |
unknownbrackets
force-pushed
the
warnings
branch
from
c4010bf
to
bf4dc05
Compare
We should get rid of deprecated usage, but it's troublesome for only UWP to compile differently. These were ignored before.
unknownbrackets
force-pushed
the
warnings
branch
from
bf4dc05
to
90f7016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some globally disabled warnings. Was helpful for #14176.
Some network related warnings (mainly inet_nota and the WSA version) are exposed. Also two
GetVersion()calls. In theory, if we update dependencies (say, glslang, spirv, etc.) this will better expose explicitly deprecated usage.-[Unknown]