Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak build on FreeBSD #13819

Merged
merged 3 commits into from
Dec 27, 2020
Merged

Unbreak build on FreeBSD #13819

merged 3 commits into from
Dec 27, 2020

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Dec 27, 2020

Probably regressed by #13172, #13427, #13489 but I haven't bisected. From error log:

Common/MemArenaPosix.cpp:111:71: error: use of undeclared identifier 'MAP_NORESERVE'
        void *base = mmap(0, EIGHT_GIGS, PROT_NONE, MAP_ANON | MAP_PRIVATE | MAP_NORESERVE, -1, 0);
                                                                             ^
Core/Instance.cpp:90:56: error: use of undeclared identifier 'PROT_READ'
        InstanceInfo *buf = (InstanceInfo *)mmap(0, BUF_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, hIDMapFile, 0);
                                                              ^
Core/Instance.cpp:90:68: error: use of undeclared identifier 'PROT_WRITE'
        InstanceInfo *buf = (InstanceInfo *)mmap(0, BUF_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, hIDMapFile, 0);
                                                                          ^
Core/Instance.cpp:90:80: error: use of undeclared identifier 'MAP_SHARED'
        InstanceInfo *buf = (InstanceInfo *)mmap(0, BUF_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, hIDMapFile, 0);
                                                                                      ^
Core/Instance.cpp:91:13: error: use of undeclared identifier 'MAP_FAILED'
        if (buf == MAP_FAILED) {
                   ^
Core/Instance.cpp:147:37: error: use of undeclared identifier 'O_CREAT'
        hIDMapFile = shm_open(ID_SHM_NAME, O_CREAT | O_RDWR, 0);
                                           ^
Core/Instance.cpp:147:47: error: use of undeclared identifier 'O_RDWR'
        hIDMapFile = shm_open(ID_SHM_NAME, O_CREAT | O_RDWR, 0);
                                                     ^
Core/Instance.cpp:185:3: error: use of undeclared identifier 'shm_unlink'
                shm_unlink(ID_SHM_NAME);     // If program exited or crashed before unlinked the shared memory object and it's contents will persist.
                ^
Core/FileSystems/FileSystem.h:102:5: error: field has incomplete type 'tm'
        tm atime{};
           ^
/usr/include/wchar.h:111:8: note: forward declaration of 'tm'
struct tm;
       ^
In file included from Core/FileSystems/FileSystem.cpp:20:
Core/FileSystems/FileSystem.h:103:5: error: field has incomplete type 'tm'
        tm ctime{};
           ^
/usr/include/wchar.h:111:8: note: forward declaration of 'tm'
struct tm;
       ^
In file included from Core/FileSystems/FileSystem.cpp:20:
Core/FileSystems/FileSystem.h:104:5: error: field has incomplete type 'tm'
        tm mtime{};
           ^
/usr/include/wchar.h:111:8: note: forward declaration of 'tm'
struct tm;
       ^

Common/MemArenaPosix.cpp:111:71: error: use of undeclared identifier 'MAP_NORESERVE'
        void *base = mmap(0, EIGHT_GIGS, PROT_NONE, MAP_ANON | MAP_PRIVATE | MAP_NORESERVE, -1, 0);
                                                                             ^
Core/FileSystems/FileSystem.h:102:5: error: field has incomplete type 'tm'
        tm atime{};
           ^
/usr/include/wchar.h:111:8: note: forward declaration of 'tm'
struct tm;
       ^
Core/Instance.cpp:90:56: error: use of undeclared identifier 'PROT_READ'
        InstanceInfo *buf = (InstanceInfo *)mmap(0, BUF_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, hIDMapFile, 0);
                                                              ^
Core/Instance.cpp:90:68: error: use of undeclared identifier 'PROT_WRITE'
        InstanceInfo *buf = (InstanceInfo *)mmap(0, BUF_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, hIDMapFile, 0);
                                                                          ^
Core/Instance.cpp:90:80: error: use of undeclared identifier 'MAP_SHARED'
        InstanceInfo *buf = (InstanceInfo *)mmap(0, BUF_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, hIDMapFile, 0);
                                                                                      ^
Core/Instance.cpp:91:13: error: use of undeclared identifier 'MAP_FAILED'
        if (buf == MAP_FAILED) {
                   ^
Core/Instance.cpp:147:37: error: use of undeclared identifier 'O_CREAT'
        hIDMapFile = shm_open(ID_SHM_NAME, O_CREAT | O_RDWR, 0);
                                           ^
Core/Instance.cpp:147:47: error: use of undeclared identifier 'O_RDWR'
        hIDMapFile = shm_open(ID_SHM_NAME, O_CREAT | O_RDWR, 0);
                                                     ^
Core/Instance.cpp:185:3: error: use of undeclared identifier 'shm_unlink'
                shm_unlink(ID_SHM_NAME);     // If program exited or crashed before unlinked the shared memory object and it's contents will persist.
                ^
@unknownbrackets unknownbrackets added this to the v1.11.0 milestone Dec 27, 2020
@unknownbrackets unknownbrackets merged commit f856d52 into hrydgard:master Dec 27, 2020
@unknownbrackets
Copy link
Collaborator

Thanks.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants