Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ge: Check stack depth based on args struct size #12946

Merged
merged 1 commit into from
May 22, 2020
Merged

Ge: Check stack depth based on args struct size #12946

merged 1 commit into from
May 22, 2020

Conversation

unknownbrackets
Copy link
Collaborator

@unknownbrackets unknownbrackets commented May 22, 2020 •
edited
Loading

Matches tests against firmware - across SDK versions. See #12908 and #12908.

See test: hrydgard/pspautotests#204

-[Unknown]

@unknownbrackets
Ge: Check stack depth based on args struct size.
5507116 
Matches tests against firmware.
@unknownbrackets unknownbrackets added this to the v1.11.0 milestone May 22, 2020
@unknownbrackets
Copy link
Collaborator Author

FYI @sum2012 @gid15. Not sure if this affects any games, but this is what actual firmware seems to do. Note that size and stackDepth are unsigned (-1 in both cases is treated as larger than 16/256.)

-[Unknown]

@hrydgard hrydgard merged commit 34b5d53 into hrydgard:master May 22, 2020
@hrydgard hrydgard modified the milestones: v1.11.0, v1.10.0 May 22, 2020
@unknownbrackets unknownbrackets deleted the ge-minor branch May 22, 2020 07:26
@sum2012
Copy link
Collaborator

sum2012 commented May 22, 2020

Thanks @unknownbrackets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@unknownbrackets @sum2012 @hrydgard