Add Test Drive Unlimited to depthRangeHack to disable range culling #12016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really had hoped we'd only need this for Phantasy Star... |
|
#11630 maybe can fix? I cannot test now |
|
Well, I think GPU_USE_DEPTH_RANGE_HACK ultimately just works around incorrect clipping/clamping in non-accurate depth path for Phantasy Star. I guess we'll say this is related to #11576 so we don't lose it. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including dump with problem this works around:
ULUS10249_0001.zip
I guess range culling causes missing road/ground, through not sure if depth range hack on it's own doesn't help as I recall seeing missing triangle or two when riding offroad even before range culling was added, it was just soo rare and hard to reproduce I thought it's game glitch, maybe range culling just made the problem more visible.