Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow > 5x PSP resolution for devices like iPad Pro 12.9 #8714

Closed
iOSSOi opened this issue Apr 27, 2016 · 19 comments
Closed

Allow > 5x PSP resolution for devices like iPad Pro 12.9 #8714

iOSSOi opened this issue Apr 27, 2016 · 19 comments

Comments

@iOSSOi
Copy link

iOSSOi commented Apr 27, 2016

I know this might not be high on the priority list, but would it be possible for you guys to optimize the emulator for the iPad Pro 12.9 screen resolution? The menus looks pretty fussy today, and it seems to affect the resolution of the games played. it would be nice to have them as sharp as possible.

Some people will probably start to complain about the games doesn't even run full speed, and that's actually true, but they are a few games does run full speed without the JIT on non-jailbroken ipad pro 12.9, even without JIT.

(that way the emulator will be ready when JIT finally can be enabled.

Would it be possible?

IPad Pro Screen Res: 2732 x 2048

@iOSSOi
Copy link
Author

iOSSOi commented May 15, 2016

I have tested a few more games, actually, a few game run full speed without jit on the 12,9 Pro. Most YS games does. Please, can we have this the optimized for the for the emulator. I hate when other people ask for optimizations like this, and now I'm the one who's asking. 😩

@unknownbrackets
Copy link
Collaborator

Speed is going to be bad in some games without jit.

We have recently implemented (mostly @hrydgard) a new, experimental interpreter - it still doesn't use jit, but it pre-processes the MIPS code to generate something that is faster to interpret. In other words, it does the 25% of what jit does, the part that is allowed on Apple devices.

Actually, this new interpreter may allow us to make jit even faster on devices that support it. So Apple devices may still lag behind everyone else in speed.

It not enabled by default, and is still buggy. But you can enable it in the latest git builds via Tools -> Developer Options. When it works, it should be faster than the interpreter.

As far as resolution, I assume you've selected a higher internal rendering resolution? You'd want to select 6x PSP to have a sharp render at that resolution, but I'm doubtful the device's GPU could keep up with such a high resolution.

Remember, 480x272 is 1x PSP. That means 4x PSP is 1920x1088 (near 1080p.) No multiple of the PSP's resolution matches the iPad Pro's, but 6x PSP is 2880x1632... whatever resolution you use, I recommend setting this to have a border around it to avoid fuzziness (in the Display Layout Editor.)

-[Unknown]

@iOSSOi
Copy link
Author

iOSSOi commented May 16, 2016

@unknownbrackets @hrydgard now i really dont know where to start. You guys are amazing, amaziiiiiiiiimg!!!!!!!!!!! With IR interpreter i can play KH:BBS in full speed on my non jail-broken ipad pro! Im using 5xPSP in buffered rendering. No hacks at all. Im only using multithreaded.

As far as the resolution, im actually speaking about the application itself, not the in-game resolution. Because the application isn't optimized for the 2732x2048, the menu of the emulator is fuzzy, and that seems to effect the games loaded. Playing at the highest resolution still makes games a little, just a little bit.

So optimizing the whole application for ipad pro (menus) and adding 6xPSP (maybe even higher, 10xPSP)really shouldn't be a bad idea.

I remeber the days when the YouTube app wasn't optimized for the resolution of the ipad pro 12.9, every video looked horrible. But when google optimized thr menus to 2732x2048, it also effected the videos. Even if the resolution of the ipad isnt 4k, the 4k videos looked alot sharper. My theory is that the same thing will happen to PPSSPP. i think upgrading the whole app to 2732x2048 will not only make the menus more sharp, even the games will. Please correct me if im wrong! This is only my theory. And if im wrong i will 🤐

@hrydgard
Copy link
Owner

hrydgard commented May 16, 2016

I don't have access to an iPad Pro at the moment. What does it look like? Is the major failing that it's simply running at the wrong resolution, or are things stretched or out of place?

Oh and good to hear that you're getting a substantial improvement :)

@iOSSOi
Copy link
Author

iOSSOi commented May 16, 2016

Nothing is out of place, its only running at the wrong/lower resolution.

@iOSSOi
Copy link
Author

iOSSOi commented May 18, 2016

@hrydgard @unknownbrackets Thinking of it, I remember the first time i booted PPSSPP on a iPhone 6 plus, the menus was messed up. If you would like to change the resolution I would be happy to leave all the feedback i possible can. If anything will seem stretched or out of order i can upload some pictures.

@iOSSOi
Copy link
Author

iOSSOi commented May 21, 2016

@unknownbrackets @hrydgard it seems that the ir interpreter isgeiiting famous on reddit. Please, please can we have this resolution upgrade + maybe 10xPSP. Please, please. Im not gonna be nagging anymore, promise🤐

@unknownbrackets unknownbrackets changed the title (iOS) Optimizing PPSSPP for iPad Pro 12.9 (iOS) Optimizing PPSSPP resolution for iPad Pro 12.9 Sep 5, 2016
@iOSSOi
Copy link
Author

iOSSOi commented Jan 29, 2017

Any chance the optimization can be ready for 1.4?

@Purpleistacky
Copy link

@iOSSOi hey! I can't get any game to launch on my iPad pro. any tips? anything in the settings? Cheers.

@iOSSOi
Copy link
Author

iOSSOi commented Aug 4, 2017

Any chanse we can get ppsspp resolution native to iPad pro 12.9 2732x2048?

@unknownbrackets
Copy link
Collaborator

Contributions are welcome, especially from contributors with iOS devices.

-[Unknown]

@unknownbrackets
Copy link
Collaborator

It sounds like this issue isn't really iOS specific, actually. It's just requesting higher render resolutions than 5x (2400x1360) for the iPad Pro (2732x2048), right?

This would in theory also affect Android tablets that are closer to "4K", like QHD.

-[Unknown]

@unknownbrackets unknownbrackets changed the title (iOS) Optimizing PPSSPP resolution for iPad Pro 12.9 Allow > 5x PSP resolution for devices like iPad Pro 12.9 Dec 29, 2017
@iOSSOi
Copy link
Author

iOSSOi commented Dec 29, 2017

Correct, an option up to 10x would be nice = )

The interface itself isnt optimised for the iPad Pro 12.9 eiter. Lunching ppsspp on the iPad Pro 12.9 (2732x2048) at the moment shows the interface in the Regular 9.7 inch resolution (2048x1536). Is it possible to bump that up to 2732x2048?

Why im asking is that the output resolution to the screen at the moment are limited to 2048x1536. Rendering anything higher than that wont actually make a difference if the app/ppsspp isnt nativly opening at 2732x2048 on the 12.9 inch.

Does that make any sense? I tend to have bad explanations, english isnt my native language = )

@AkiraMiyakoda
Copy link
Contributor

More than 5x window sizes would be nice for Windows/Linux with 4K (or more) displays too.

@hrydgard
Copy link
Owner

hrydgard commented Jan 2, 2018

Maybe @KentuckyCompass has some idea about how to tell iOS that we want to use the full resolution of an iPad Pro 12.9?

@KentuckyCompass
Copy link
Contributor

iOS checks whether an app supports certain resolutions based on the presence of a launch screen or otherwise launch images of the correct sizes. If not, you get a legacy resolution. That's most likely what's happening to PPSSPP on the iPad Pro. Here's a stackoverflow thread about it.

A launch screen can be easier because you do it once in a WYSIWYG UI designer and specify how it scales, as opposed to a half dozen images that need special sizes and filenames. I'm still figuring out how to make CMake cooperate.

We just need to decide what launching should look like. See Apple's guidelines. They discourage showing a logo and recommend just the background of the app without foreground stuff like text. Maybe just the blue gradient?

@hrydgard
Copy link
Owner

hrydgard commented Jan 4, 2018

Ah, so that's what it is. The blue gradient would be perfect.

@JuliusSenkus
Copy link
Contributor

JuliusSenkus commented Apr 13, 2020

Hi,

Came here from #12815 (TL;DR agreed to test performance of 10x, 9x, 8x etc on my owned devices and if it seemed reasonable create PR to enable this functionality for all devices).

Tested on Samsung Galaxy S8 (Exynos 8895), Samsung Tab s5e and Khadas VIM3 Pro (connected 4k display).

Benchmarks for comparison:

Tested games:
Valkyria Chronicles III(with english patch applied) Sweet spot somewhere around 6x for S5e and VIM3, but S8 can run it on 10x (only in title meniu game speed drops to ~90%).
Need for Speed: Most Wanted (PSP) S8 can run 9x, others 7x.
Tekken 6 Have not managed to run 100% speed on any device even on 1x.
Also looked into DBZ Tag team, only on S8, 5x seems to be a lot.

Summary:
Useful only for flagship devices and not counting downscaling, full 10x resolution is used with external monitors (Samsung Dex, Android 10 Desktop etc). Might create influx of issues in github from users with with lower end devices.

JuliusSenkus added a commit to JuliusSenkus/ppsspp that referenced this issue Apr 13, 2020
hrydgard added a commit that referenced this issue Apr 13, 2020
#8714 Unified resolution scaling for all platforms.
@unknownbrackets
Copy link
Collaborator

I'm going to close this now given #12821. There are still issues I think on some iOS devices, but that's covered in #11677 and really a separate problem from render resolution.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.10.0 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants