Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature for sharing url #95

Merged
merged 11 commits into from
Jun 24, 2024
Merged

feature for sharing url #95

merged 11 commits into from
Jun 24, 2024

Conversation

hrgdavor
Copy link
Owner

@hrgdavor hrgdavor commented Feb 21, 2024

implement share url function to export current script as gzipped data url

inital lame version adds a menu item to export
image

copies the url to clipboard, and writes url to console

todo

  • ui feedback
  • will not work for multifile projects a warnign to user should be displayed ...
  • we also need some kind of state to know if current script is multifile

@hrgdavor hrgdavor changed the title feature for sharing url WIP: feature for sharing url Feb 21, 2024
@Hermann-SW
Copy link
Contributor

Sounds good.
You might want to evaluate whether copying into address bar is more intuitive for you.
You can see what I mean by clicking on "Share" button on GraphvizFiddle and watch address bar:
https://stamm-wilbrandt.de/GraphvizFiddle/
It copies current .dot file from editor window into URL, so that it can be shared or stored (urlencoded).

@hrgdavor
Copy link
Owner Author

That is one possible option, I am now thinking for save button and ctrl+s shortcut to have multichoice

  • update url
  • copy to clipboard
  • save to file

This is WIP, and I have not decided on final details

@Hermann-SW
Copy link
Contributor

I forgot one plus point of "save to address bar" — you can easily create a bookmark from that URL.

@hrgdavor hrgdavor changed the title WIP: feature for sharing url feature for sharing url Jun 22, 2024
@hrgdavor hrgdavor requested a review from platypii June 22, 2024 20:58
Copy link
Collaborator

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good 👍

@hrgdavor hrgdavor merged commit 7f8fe04 into main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants