-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photovoltaics Changes #70
Conversation
@@ -1732,6 +1732,9 @@ | |||
<xs:restriction base="xs:string"> | |||
<xs:enumeration value="leased"/> | |||
<xs:enumeration value="owned"/> | |||
<xs:enumeration value="power purchase agreement"/> | |||
<xs:enumeration value="utility owned"/> | |||
<xs:enumeration value="other"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gavinhastings @RebHudson Do these enumerations for PVSystem/Ownership
looks reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those enumerations work for me
From @RebHudson Annual Output could be “actual” or “projected”. These would need to be enumerations for the value. Actual would be a measured value of the full year’s energy output in kWh/year. It would be great to have a year associated with that value. There is a simplified version of an output calculator: For levelized cost of electricity, it also involves a calculation that could be done in different ways. A good definition from SAM (NREL created a SAM model that has a method for calculating LCOE https://www.nrel.gov/analysis/sam/help/html-php/index.html?mtf_lcoe.htm) is: The LCOE is the total cost of installing and operating a project expressed in dollars per kilowatt-hour of electricity generated by the system over its life. http://www.nrel.gov/analysis/tech_lcoe.html seems to have a simpler version. |
I added the following definitions AnnualOutput
I decided to go with the projected because that's what more people are likely to have. It's fairly simple to calculate too. Levelized Cost of Electricity
|
<xs:element minOccurs="0" name="AnnualOutput" | ||
type="RatedAnnualkWh"> | ||
<xs:annotation> | ||
<xs:documentation>[kWh] Projected Annual Output for a typical meterological year as determined by PVWatts. </xs:documentation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "or similar"
Review: @brandongallagher @GamalielL |
Looks good to me. I've asked Andy to review as well. |
works for me. i'm looking forward to the AnnualOutput field. that will help us. |
AnnualOutput
.LevelizedCostOfElectricity
.@RebHudson
Fixes #53
Fixed #54