Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More window shading options #418

Merged
merged 14 commits into from
Aug 30, 2024
Merged

More window shading options #418

merged 14 commits into from
Aug 30, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jun 25, 2024

  • Updates InteriorShading:
    • Adds Type options: "medium blinds", "medium shades", and "medium curtains" (dark/light already exist).
    • Adds BlindsSummerClosedOrOpen and BlindsWinterClosedOrOpen elements w/ options of "closed", "open", and "half open".
    • Adds SummerFractionCovered and WinterFractionCovered elements w/ a fraction between 0-1.
  • Adds an InsectScreen element with properties:
    • Location element w/ options of "interior" and "exterior".
    • SummerFractionCovered and WinterFractionCovered elements w/ a fraction between 0-1.
    • Condition element w/ options of "good", "moderate", and "poor".

image

image

@shorowit shorowit added this to the v4.1 milestone Jun 25, 2024
@shorowit shorowit self-assigned this Jun 25, 2024
@shorowit shorowit changed the title Allow medium interior shading enumerations More window shading options Jul 5, 2024
@shorowit shorowit changed the title More window shading options More interior shading options Jul 5, 2024
@shorowit shorowit changed the title More interior shading options More window shading options Jul 5, 2024
@shorowit
Copy link
Contributor Author

shorowit commented Aug 8, 2024

Split InsectScreen/FractionCovered into Summer and Winter versions.

@shorowit shorowit added the merge label Aug 8, 2024
@nmerket nmerket merged commit d45f425 into master Aug 30, 2024
2 checks passed
@nmerket nmerket deleted the medium_shading branch August 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants