Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require HVAC & water heater setpoints to be greater than zero #410

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

shorowit
Copy link
Contributor

Continuing my mission to stop software from writing zeroes for elements when they should omit them if they don't apply.

This requires temperatures to be > 0 for:

  • WaterHeatingSystem/HotWaterTemperature
  • HVACControl/SetpointTempHeatingSeason
  • HVACControl/SetbackTempHeatingSeason
  • HVACControl/SetupTempCoolingSeason
  • HVACControl/SetpointTempCoolingSeason

@shorowit shorowit added this to the v4.1 milestone Apr 19, 2024
@shorowit shorowit added the merge label Jun 13, 2024
@shorowit shorowit requested a review from nmerket June 13, 2024 21:19
@nmerket nmerket merged commit b08a32e into master Jul 11, 2024
2 checks passed
@nmerket nmerket deleted the hvac_dhw_temperatures branch July 11, 2024 15:17
@nmerket nmerket modified the milestones: v4.1, v4.0-rc5 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants