Adds FrameFloor/FloorOrCeiling element
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One comment from WG: While we are changing FrameFloor to Floor, rename to a more generic term? |
Others have struggled with this: https://english.stackexchange.com/questions/191958/is-there-a-common-word-for-floor-and-ceiling |
|
I like this idea!! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253. Adds
Floor/FloorOrCeiling: string (choices: "floor", "ceiling"). From the perspective of the living/conditioned space. Often it can be inferred from other information in the HPXML, but not always. This is particularly useful because a lot of standards (like IECC, ANSI 301, etc.) refer to ceilings and floors.(I'm not calling it
FloorTypebecause that is being used here to support wood frame floors vs mass floors vs ...).This is a far simpler implementation than adding an
Enclosure/Ceilingselement, which would require a lot of software updates.Should we also deprecate (or mark as deprecated) the "other housing unit above" and "other housing unit below" AdjacentTo enumerations? This is a more flexible implementation and can be used for adjacent locations other than just "other housing unit".