Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window/Skylight Interior Shading Fraction #189

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Sep 6, 2019

For windows/skylights, splits InteriorShadingFraction into InteriorShadingFractionSummer and InteriorShadingFractionWinter. Many software tools and standards use two different numbers.

Copy link
Contributor

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I do have questions about when each factor applies. Should we be providing a way to better specify that?

@nmerket nmerket added the merge label Sep 10, 2019
@nmerket nmerket merged commit 5214e25 into master Sep 24, 2019
@nmerket nmerket deleted the interior_shading_fraction branch September 24, 2019 16:44
@nmerket nmerket added this to the v3.0 milestone Oct 30, 2019
@lirainer
Copy link

lirainer commented Nov 4, 2019

@nmerket Excuse my git-ignorance, but seems we should note that all these changes have been superseded by #202?

@shorowit
Copy link
Contributor Author

shorowit commented Nov 4, 2019

@lirainer What do you mean? The change is preserved in #202, aside from being renamed to SummerShadingCoefficient and WinterShadingCoefficient:

image

@lirainer
Copy link

lirainer commented Nov 4, 2019

I guess what I'm trying to say is that the changes made in this PR never show up in 3.0 (especially if all the commits are squashed?) It was confusing to me to see the ShadingFraction elements show up here when we ended up using ShadingCoefficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants