Other small fixes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XapaJIaMnu
commented
Aug 17, 2023
XapaJIaMnu
commented
Aug 17, 2023
| @@ -62,4 +62,4 @@ def setup_logger(outputfilename: Optional[str] = None, loglevel: str = "INFO", d | |||
| # even if it has already been shutdown. This is why we use force=True to force recreation of logger so we can | |||
| # properly run our tests. Not the best solution, not sure if it's not prone to race conditions, but it is | |||
| # at the very least safe to use for the actual software running | |||
| logging.basicConfig(handlers=handlers, level=get_log_level(loglevel), format=loggingformat, datefmt='%Y-%m-%d %H:%M:%S', force=True, **kwargs) | |||
There was a problem hiding this comment.
I don't understand the purpose of **kwargs here?
There was a problem hiding this comment.
It's because you added encoding='utf-8' but the encoding argument is only available since Python 3.9. So a couple of lines above this one I only set kwargs to included the encoding bit if Python is 3.9 or higher.
There was a problem hiding this comment.
oh, right.. Will fix. it
jelmervdl
reviewed
Aug 17, 2023
jelmervdl
reviewed
Aug 17, 2023
jelmervdl
reviewed
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few fixes to make the linter happy.