Fix Stage modifiers not applying + tests #22

XapaJIaMnu · 2023-06-25T21:15:35Z

Fix + tests

jelmervdl

Let me know whether you agree with that explicit modifier list combination is better than implicit concatenation, and I'll push my changes to support it.

src/opustrainer/trainer.py

tests/test_endtoend.py

Note that I changed how line modifiers are wrapped so that they look more like classes, and checking for them in tests is more straightforward.

Also makes it more explicit that it is wrong, and correctly raises a `Tags modifier should to be the last modifier to be applied, as otherwise other modifiers might alter the inserted tags themselves.` warning.

Fix Stage modifiers not applying + tests

ef6e47b

XapaJIaMnu requested a review from jelmervdl June 25, 2023 21:15

jelmervdl reviewed Jun 30, 2023

View reviewed changes

src/opustrainer/trainer.py Outdated Show resolved Hide resolved

src/opustrainer/trainer.py Outdated Show resolved Hide resolved

tests/test_endtoend.py Outdated Show resolved Hide resolved

XapaJIaMnu and others added 5 commits June 30, 2023 10:45

....that was bad....

b77babe

Stage modifiers override global modifiers

d2b2ce2

Flatten modifier lists to make it easier to extend lists in YAML

13fe402

Add test for YAML-reference extend modifier lists

6bc3f85

Note that I changed how line modifiers are wrapped so that they look more like classes, and checking for them in tests is more straightforward.

Update advanced config test

b2866e3

Also makes it more explicit that it is wrong, and correctly raises a `Tags modifier should to be the last modifier to be applied, as otherwise other modifiers might alter the inserted tags themselves.` warning.

jelmervdl merged commit e06fb84 into main Jun 30, 2023

jelmervdl deleted the bugfix_advanced_modifiers branch June 30, 2023 11:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Stage modifiers not applying + tests #22

Fix Stage modifiers not applying + tests #22

XapaJIaMnu commented Jun 25, 2023

jelmervdl left a comment

Fix Stage modifiers not applying + tests #22

Fix Stage modifiers not applying + tests #22

Conversation

XapaJIaMnu commented Jun 25, 2023

jelmervdl left a comment

Choose a reason for hiding this comment