BC-1990 - Avoid async calls in the feathers setup method #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid race condition when db is not fully up, while the setup method, aka service initialization, is called, which on occasion can happen on deployment in K8 cluster. Calling the db "too early" was essentially caching a bad response like undefined in a prop of the class.
|
interesting topic: feathersjs/feathers#509 (comment) |
MartinSchuhmacher
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid race condition when db is not fully up, while the setup method,
aka service initialization, is called, which on occasion can happen on
deployment in K8 cluster.
Calling the db "too early" was essentially caching a bad response
like undefined in a prop of the class.
Links to Tickets or other pull requests
BC-1990
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review