Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(thrift): Correct REF in portfile.cmake #38

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(thrift): Correct REF in portfile.cmake #38

merged 1 commit into from
Jul 23, 2024

Conversation

GordonSmith
Copy link
Member

No change the CRC hash

@GordonSmith
fix(thrift): Correct REF in portfile.cmake
faec50f 
No change the CRC hash

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Michael-Gardner
Michael-Gardner approved these changes Jul 23, 2024
View reviewed changes
Copy link

@Michael-Gardner Michael-Gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a fresh 22.04 container.

Confirmed the original issue existed.

Swapped vcpkg submodules branch to gordonSmith/THRIFT_ISSUE for testing

-DCMAKE_BUILD_TYPE=Debug -DINCLUDE_PLUGINS=ON

confirmed Thrift built. Then built entire package.

@GordonSmith GordonSmith merged commit 70ea56a into hpcc-systems:hpcc-platform-9.8.x Jul 23, 2024
1 check passed
@GordonSmith GordonSmith deleted the THRIFT_ISSUE branch July 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-Gardner Michael-Gardner Michael-Gardner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @Michael-Gardner