Add support for the canon output format
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support the [`canon`](https://graphviz.gitlab.io/docs/outputs/canon/) format, to allow formatting DOT files without performing any layout.
GordonSmith
requested changes
Sep 16, 2024
| @@ -4,7 +4,7 @@ import load, { reset } from "../../../build/packages/graphviz/src-cpp/graphvizli | |||
| /** | |||
| * Various graphic and data formats for end user, web, documents and other applications. See [Output Formats](https://graphviz.gitlab.io/docs/outputs/) for more information. | |||
| */ | |||
| export type Format = "svg" | "dot" | "json" | "dot_json" | "xdot_json" | "plain" | "plain-ext"; | |||
| export type Format = "svg" | "dot" | "json" | "dot_json" | "xdot_json" | "plain" | "plain-ext" | "canon"; | |||
There was a problem hiding this comment.
Can you also add here: https://github.com/hpcc-systems/hpcc-js-wasm/blob/trunk/packages/graphviz/test/graphviz.ts
Thx for the PR!!!
|
Thanks for the super fast response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the
canonformat, to allow formatting DOT files without performing any layout.This works today, but the type-checker is not happy about it. So I want to add it to the
Formatoptions.