Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for NodeJS CJS package #4333

Merged
merged 1 commit into from
Jan 31, 2025
Merged

feat: Add support for NodeJS CJS package #4333

merged 1 commit into from
Jan 31, 2025

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 30, 2025 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg January 30, 2025 14:15
@GordonSmith
feat: Add support for NodeJS CJS package
658e0fd 
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit cd5cb90 into hpcc-systems:candidate-3.x.x Jan 31, 2025
1 check passed
@GordonSmith GordonSmith deleted the COMMON_JS branch January 31, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg