Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkpointio] fix performance issue #6139

Merged

Conversation

ver217
Copy link
Member

@ver217 ver217 commented Nov 18, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 requested a review from a team as a code owner November 18, 2024 05:59
@ver217 ver217 merged commit 9664ed7 into hpcaitech:feature/async-checkpointio Nov 18, 2024
2 of 3 checks passed
@ver217 ver217 deleted the hotfix/ckpt-clean branch November 18, 2024 08:41
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Nov 18, 2024
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Nov 18, 2024
ver217 added a commit that referenced this pull request Nov 19, 2024
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants