Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat] Add KTO #5922

Merged
merged 13 commits into from
Jul 29, 2024
Merged

[Chat] Add KTO #5922

merged 13 commits into from
Jul 29, 2024

Conversation

YeAnbang
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@YeAnbang YeAnbang requested a review from a team as a code owner July 18, 2024 08:17
@YeAnbang YeAnbang requested a review from TongLi3701 July 18, 2024 08:40
@TongLi3701
Copy link
Member

@YeAnbang Seem that you need to rename testing data.

Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang.

Some comments.

applications/ColossalChat/benchmarks/benchmark_kto.py Outdated Show resolved Hide resolved
applications/ColossalChat/coati/dataset/utils.py Outdated Show resolved Hide resolved
applications/ColossalChat/coati/trainer/kto.py Outdated Show resolved Hide resolved
@TongLi3701 TongLi3701 self-requested a review July 28, 2024 02:16
Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang.

Overall looks good. Just some minor questions.

@YeAnbang YeAnbang merged commit c8332b9 into main Jul 29, 2024
4 checks passed
@YeAnbang YeAnbang deleted the kto branch August 2, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants