Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shardformer] add assert for num of attention heads divisible by tp_size #5670

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

wangbluo
Copy link
Contributor

Added an assertion for the number of attention heads being divisible by the TP size dimension for the Shardformer.

@wangbluo wangbluo requested a review from a team as a code owner April 28, 2024 10:54
@wangbluo wangbluo changed the title add assert for num of attention heads divisible by tp_size [Shardformer] add assert for num of attention heads divisible by tp_size Apr 29, 2024
@ver217 ver217 marked this pull request as draft April 29, 2024 07:41
@ver217 ver217 marked this pull request as ready for review April 29, 2024 07:41
@ver217 ver217 merged commit d3f34ee into hpcaitech:main Apr 29, 2024
8 checks passed
wangbluo added a commit to wangbluo/ColossalAI that referenced this pull request May 7, 2024
…ize (hpcaitech#5670)

* add assert for num of attention heads divisible by tp_size

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@wangbluo wangbluo deleted the add_assert branch August 17, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants