Fix for issue dsync not updating times correctly #560. #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonneau1
changed the title
carbonneau1
force-pushed
the
eric_mfu_dev
branch
from
d057303 to
58d7a8b
Compare
ofaaland
reviewed
Jan 17, 2025
Some file system do not support nanosecond part of the timespec for mtime (last modification time). We were comparing the mtime regardless of the support to mtime nanosecond. This was causing dsync to add files to the copy to destination list even if the file were identical. We added a check for source dir and destination dir to verify if the timepsec nanosecond (tv_nsec) was set to 0. In which case we do not compare the mtime nanosecond part of it (tv_nsec). Cleaning up dead code left in the source files. dsync.c and mfu_flist_copy.c Cleaned up code of unused code and reverted src/common/mfu_flist_copy.c The change in mfu_flist_copy.c is for another MR.
carbonneau1
force-pushed
the
eric_mfu_dev
branch
from
58d7a8b to
88f9015
Compare
ofaaland
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some file system do not support nanosecond part of the timespec for mtime (last modification time). We were comparing the mtime (tv_nsec nanosecond) regardless of the support to mtime nanosecond. This was causing dsync to add files to the copy to destination list even if the file were identical.
We added a check for source dir and destination dir to verify if the timepsec nanosecond (tv_nsec) was set to 0. In which case we do not compare the mtime nanosecond part of it (tv_nsec).