dfilemaker: pass correct pointer to mfu_free() #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit commit fc70c2c Author: Olaf Faaland <faaland1@llnl.gov> Date: Thu Nov 14 15:44:34 2024 -0800 dfilemaker: address review comments for PR hpc#269 introduced an error. mfu_free() takes a pointer to a pointer, because it both frees the memory, and also sets the pointer to NULL to prevent double-free bugs. The above commit passed the address of the memory to be freed, not the address of the pointer. This meant both that the wrong memory was freed, potentially, and also that the code attempted to set some arbitrary set of bytes to NULL. In testing, this triggered a segfault when running dfilemaker. Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
commit fc70c2c
Author: Olaf Faaland faaland1@llnl.gov
Date: Thu Nov 14 15:44:34 2024 -0800
introduced an error. mfu_free() takes a pointer to a pointer, because it both frees the memory, and also sets the pointer to NULL to prevent double-free bugs.
The above commit passed the address of the memory to be freed, not the address of the pointer. This meant both that the wrong memory was freed, potentially, and also that the code attempted to set some arbitrary set of bytes to NULL.
In testing, this triggered a segfault when running dfilemaker.