test_dsync: add test_expectfail.sh, test_existence.sh, and stubs for two other tests #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gonsie @carbonneau1 I intend this to be a template for other tests, so this is a good time to discuss or object to anything about how I implemented these tests - writing tests as shell scripts, the organization of the tests, the fact that they're single-node tests, etc. Thanks! |
carbonneau1
reviewed
Nov 6, 2024
carbonneau1
approved these changes
Nov 6, 2024
|
Hi @carbonneau1 please see the two new commits, running dsync under "mpirun", and copying a directory tree from /usr/include for use as test data. |
ofaaland
force-pushed
the
b-dsync-test-noopts-2
branch
from
bf5030b to
0421087
Compare
carbonneau1
approved these changes
Nov 6, 2024
ofaaland
force-pushed
the
b-dsync-test-noopts-2
branch
6 times, most recently
from
71b1c88 to
8e76635
Compare
daltonbohning
approved these changes
Nov 12, 2024
test/tests/test_dsync/test_data.sh
Outdated
| # - file with differing data is not copied if --contents arg is not used and metadata match | ||
| # | ||
| # Notes: | ||
| # - does not test whether data copes are spread across nodes/tasks evenly |
There was a problem hiding this comment.
Suggested change
| # - does not test whether data copes are spread across nodes/tasks evenly | |
| # - does not test whether data copies are spread across nodes/tasks evenly |
ofaaland
force-pushed
the
b-dsync-test-noopts-2
branch
from
8e76635 to
10d9b98
Compare
Add a small set of bash functions for performing set operations, for use with dsync tests. Add a small test driver and two data files for testing the bash functions. Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Add the following tests: test_expectfail.sh: add tests for missing source or destination parent test_existence.sh: verify set of files synced is correct Add stubs for the following tests: test_metadata.sh: verify metadata of synced files is correct test_data.sh: verify data in synced files is correct Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
ofaaland
force-pushed
the
b-dsync-test-noopts-2
branch
from
10d9b98 to
91611a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following tests:
Add stubs for the following tests:
Add a small set of bash functions for performing set operations, for use with dsync tests.
Add a small test driver and two data files for testing the bash functions.