Daos api update API: daos_cont_open only supports uuid string. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
object format will be changed since 2.0, this patch adds codes to be aware of new changes. PR-repos-el7: daos@PR-6752 PR-repos-el8: daos@PR-6752 PR-repos-leap15: daos@PR-6752 Signed-off-by: Wang Shilong <shilong.wang@intel.com>
daos: fix to support new DAOS api
daos_cont_open only supports container uuid string. uuid_t has to be converted to string. Signed-off-by: Lei Huang <wiliam_huang@hotmail.com>
There was a problem hiding this comment.
@wiliamhuang The daos-stack/hpc fork diverged from hpc/mpifileutils for a temporary fix that is now in upstream. If creating a PR from daos-stack/hpc, you'll want to rebase on hpc/master first.
daos_cont_open only supports container uuid string. uuid_t has to be converted to string. Signed-off-by: Lei Huang <wiliam_huang@hotmail.com>
…pifileutils into daos_api_update_lei Signed-off-by: Lei Huang <wiliam_huang@hotmail.com>
daltonbohning
approved these changes
Feb 18, 2022
|
@adammoody I'm going ahead and merging this one since the change is just one line, contained to DAOS only, and we'd like to update our internal tests accordingly. |
|
No problem. Thanks @wiliamhuang and @daltonbohning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to convert uuid_t to string then pass it to daos_cont_open().