refactor: upgrade for node20 #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkainzinger
force-pushed
the
main
branch
2 times, most recently
from
4385ed4 to
3975ce8
Compare
rchabin
approved these changes
Feb 13, 2024
|
Do we have an update on when this PR will be merged? |
|
I guess until merged I can only recommend using my fork |
neilime
force-pushed
the
main
branch
3 times, most recently
from
70b5480 to
d803d60
Compare
|
@neilime I guess I cannot contribute to this anymore, pipeline fails with something I cannot fix I would assume |
|
We are working to refactoring to typescript and migrating to node 20, new release will be available very soon |
|
@alexkainzinger the migration on node 20 is done, thank you for you PR for inspiration. I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, contributing to make this run with node20 due to https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
code is not touched at all, just removing
node_modules/folder because it is now compiled instead with ncc and put todist/folder. this also bumps all packages to its newest version, rest is just search and replace node16 with node20I tested it in my private repo using my published v2:
alexkainzinger/compose-action@v2(https://github.com/alexkainzinger/compose-action/tree/v2) and it worked like a charm