Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support DataType Map #370

Merged
merged 2 commits into from
Sep 14, 2021
Merged

support DataType Map #370

merged 2 commits into from
Sep 14, 2021

Conversation

zyklon2
Copy link
Contributor

@zyklon2 zyklon2 commented Sep 13, 2021

No description provided.

@zyklon2
Copy link
Contributor Author

zyklon2 commented Sep 13, 2021

can anyone review this?

@zyklon2 zyklon2 mentioned this pull request Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #370 (7b33e61) into master (701baaf) will increase coverage by 0.07%.
The diff coverage is 60.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #370      +/-   ##
============================================
+ Coverage     61.90%   61.97%   +0.07%     
- Complexity     1192     1222      +30     
============================================
  Files           131      133       +2     
  Lines          6418     6549     +131     
  Branches        475      502      +27     
============================================
+ Hits           3973     4059      +86     
- Misses         2178     2214      +36     
- Partials        267      276       +9     
Impacted Files Coverage Δ
...thub/housepower/data/type/complex/DataTypeMap.java 40.27% <40.27%> (ø)
...ain/java/com/github/housepower/data/ColumnMap.java 81.57% <81.57%> (ø)
...c/statement/ClickHousePreparedInsertStatement.java 53.01% <83.33%> (+3.66%) ⬆️
...java/com/github/housepower/data/ColumnFactory.java 90.00% <100.00%> (+2.50%) ⬆️
...va/com/github/housepower/data/DataTypeFactory.java 87.50% <100.00%> (+0.40%) ⬆️
...ava/com/github/housepower/settings/SettingKey.java 99.30% <100.00%> (+<0.01%) ⬆️
...m/github/housepower/jdbc/ClickHouseConnection.java 54.20% <0.00%> (+0.93%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701baaf...7b33e61. Read the comment docs.

@zyklon2 zyklon2 requested a review from sundy-li September 13, 2021 10:39
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundy-li sundy-li merged commit 0ca2e83 into housepower:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants