Ensure turbo no longer uses replaceChildren

[MaxHatfull]

This method does not exist in older versions of safari (only 14+). This
meand a polyfill would be required in order to use turbo when using the
update action. In order to stop this, we replace the call to this
function with native code.

[seanpdoyle]

Since there is a pre-existing issue that mentions this method, I wonder if it'd be better to encourage applications to depend on something like @github/browser-support or another polyfill?

@keithamus do you have an opinion on this?

[MaxHatfull]

Since there is a pre-existing issue that mentions this method, I wonder if it'd be better to encourage applications to depend on something like @github/browser-support or another polyfill?

@keithamus do you have an opinion on this?

Do you have a supported browser version list? The replaceChildren method isn't very well supported.

[keithamus]

This seems fine to me. 👍

[seanpdoyle]

@MaxHatfull if we're going to go forward with rolling back the replaceChildren calls, what do you think about implementing update in terms of the polyfill:

function replaceChildren(this: Element | Document | DocumentFragment, ...children: Node[]) {
   while (this.firstChild) this.removeChild(this.firstChild)
   this.append(...children)
 }

update() {
  for (const targetElement of this.targetElements) {
    replaceChildren(targetElement, this.templateContent)
  }
}

[MaxHatfull]

I did think about that, the reason I didn't do that in this PR is to minimise the blast radius of this change. If you think this won't affect the projects of the people using hotwire and you think this is clearer, then I think it's a good idea. There's also the question of "is this simpler?" which I don't think it is as unsetting the innerHTML and setting the child to the template is what I'd expect to see when investigating a method called "update".

[MaxHatfull]

@seanpdoyle Would you be able to run the workflow? I'm not entirely sure of the process for getting this merged

[seanpdoyle]

@kevinmcconnell are you able to execute CI on this branch?

[MaxHatfull]

@kevinmcconnell could you run this again please? it looks like it is failing because of issues unrelated to the changes

[kevinmcconnell]

@MaxHatfull we had some outdated packages that were causing the CI issues. Can you rebase your changes onto the latest main to pick those up? Doing that should solve the failures. Thanks!

[MaxHatfull]

@kevinmcconnell that's the rebase done

[kevinmcconnell]

@MaxHatfull PR looks great btw. Thanks for taking care of it 🙏