Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancelable turbo:frame-click event #788

Closed
wants to merge 2 commits into from
Closed

Add cancelable turbo:frame-click event #788

wants to merge 2 commits into from

Conversation

manuelpuyol
Copy link
Contributor

Similar to turbo:click, turbo:frame-click indicates when a frame link was clicked. The event can be canceled to let the browser fallback to the default click.

@manuelpuyol manuelpuyol mentioned this pull request Nov 4, 2022
Open
@manuelpuyol manuelpuyol marked this pull request as ready for review November 8, 2022 17:02
@dhh
Copy link
Member

dhh commented Nov 27, 2022

What's the reason turbo:click can't work directly for frame clicks?

@manuelpuyol
Copy link
Contributor Author

What's the reason turbo:click can't work directly for frame clicks?

there's some context in #610

@manuelpuyol manuelpuyol mentioned this pull request Mar 20, 2023
Open
13 tasks
@manuelpuyol manuelpuyol closed this by deleting the head repository Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelpuyol @dhh