Merge in remaining header elements (eg: link icons, manifest, meta and title) #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhh could you grant permission to run CI for this change? |
|
Hmm. It’s not offering the choice to run it on this PR. Not quite sure why. We have it on for other PRs. |
|
Warning disappeared for me too. Pushed a spacing change and it is back. Could you try once more? |
|
Thanks. I need another manual trigger now that I've fixed the lint warnings. |
michaelkedar
referenced
this pull request
in google/osv.dev
Feb 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@hotwired/turbo](https://turbo.hotwired.dev) ([source](https://togithub.com/hotwired/turbo)) | [`7.2.4` -> `7.2.5`](https://renovatebot.com/diffs/npm/@hotwired%2fturbo/7.2.4/7.2.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [lit](https://lit.dev/) ([source](https://togithub.com/lit/lit)) | [`2.5.0` -> `2.6.1`](https://renovatebot.com/diffs/npm/lit/2.5.0/2.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [sass](https://togithub.com/sass/dart-sass) | [`1.57.1` -> `1.58.0`](https://renovatebot.com/diffs/npm/sass/1.57.1/1.58.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>hotwired/turbo</summary> ### [`v7.2.5`](https://togithub.com/hotwired/turbo/releases/tag/v7.2.5) [Compare Source](https://togithub.com/hotwired/turbo/compare/v7.2.4...v7.2.5) #### What's Changed - Only snapshot frame visits that have actions by [@​kevinmcconnell](https://togithub.com/kevinmcconnell) in [https://github.com/hotwired/turbo/pull/827](https://togithub.com/hotwired/turbo/pull/827) - Skip Snapshot Caching for redirect visits by [@​seanpdoyle](https://togithub.com/seanpdoyle) in [https://github.com/hotwired/turbo/pull/804](https://togithub.com/hotwired/turbo/pull/804) - Fix: Promoting lazy-loaded Frames by [@​seanpdoyle](https://togithub.com/seanpdoyle) in [https://github.com/hotwired/turbo/pull/790](https://togithub.com/hotwired/turbo/pull/790) - Merge in remaining header elements (eg: link icons, manifest, meta and title) by [@​scuml](https://togithub.com/scuml) in [https://github.com/hotwired/turbo/pull/752](https://togithub.com/hotwired/turbo/pull/752) - Allow users to define an async custom render function by [@​manuelpuyol](https://togithub.com/manuelpuyol) in [https://github.com/hotwired/turbo/pull/782](https://togithub.com/hotwired/turbo/pull/782) - Allow for listening to turbo events raised from within the Shadow DOM by [@​yuki24](https://togithub.com/yuki24) in [https://github.com/hotwired/turbo/pull/802](https://togithub.com/hotwired/turbo/pull/802) - Ensure turbo no longer uses replaceChildren by [@​MaxHatfull](https://togithub.com/MaxHatfull) in [https://github.com/hotwired/turbo/pull/808](https://togithub.com/hotwired/turbo/pull/808) - Add better support for shadow DOM by [@​yuki24](https://togithub.com/yuki24) in [https://github.com/hotwired/turbo/pull/758](https://togithub.com/hotwired/turbo/pull/758) - Fix: When applications embed [Google Adsense](https://www.google.com/adsense/start/)-powered <iframe> elements, the snippets they provide render them with a \[name] attribute that's set to the empty string "" by [@​seanpdoyle](https://togithub.com/seanpdoyle) in [https://github.com/hotwired/turbo/pull/835](https://togithub.com/hotwired/turbo/pull/835) **Full Changelog**: hotwired/turbo@v7.2.4...v7.2.5 </details> <details> <summary>lit/lit</summary> ### [`v2.6.1`](https://togithub.com/lit/lit/blob/HEAD/packages/lit/CHANGELOG.md#​261) [Compare Source](https://togithub.com/lit/lit/compare/lit@2.6.0...lit@2.6.1) ##### Patch Changes - [#​3526](https://togithub.com/lit/lit/pull/3526) [`65e56655`](https://togithub.com/lit/lit/commit/65e56655b73d22172647c1a748e7a907ad0227c0) - Disable ShadyDOM noPatch in Node dev build. This fixes the issue of throwing due to undefined `window`. - [#​3561](https://togithub.com/lit/lit/pull/3561) [`e5c254e9`](https://togithub.com/lit/lit/commit/e5c254e96cb5d0f770ec616332e231559325c5c5) - Fix built-in shimming of `HTMLElement` for Node build of `reactive-element` to respect existing `HTMLElement` in global ### [`v2.6.0`](https://togithub.com/lit/lit/blob/HEAD/packages/lit/CHANGELOG.md#​260) [Compare Source](https://togithub.com/lit/lit/compare/lit@2.5.0...lit@2.6.0) ##### Minor Changes - [#​3522](https://togithub.com/lit/lit/pull/3522) [`72fcf0d7`](https://togithub.com/lit/lit/commit/72fcf0d70b4f4644e080e9c375a58cf8fc35e9e8) - When running in Node, Lit now automatically includes minimal DOM shims which are sufficient for most SSR (Server Side Rendering) use-cases, removing the need to import the global DOM shim from `@lit-labs/ssr`. The new `@lit-labs/ssr-dom-shim` package has been introduced, which exports an `HTMLElement`, `CustomElementRegistry`, and default `customElements` singleton. The existing `@lit-labs/ssr` global DOM shim can still be used, and is compatible with the new package, because `@lit-labs/ssr` imports from `@lit-labs/ssr-dom-shim`. Importing the global DOM shim adds more APIs to the global object, such as a global `HTMLElement`, `TreeWalker`, `fetch`, and other APIs. It is recommended that users try to remove usage of the `@lit-labs/ssr` DOM shim, and instead rely on the more minimal, automatic shimming that `@lit/reactive-element` now provides automatically. ##### Patch Changes - Updated dependencies \[[`72fcf0d7`](https://togithub.com/lit/lit/commit/72fcf0d70b4f4644e080e9c375a58cf8fc35e9e8)]: - [@​lit/reactive-element](https://togithub.com/lit/reactive-element)[@​1](https://togithub.com/1).6.0 - lit-html@2.6.0 </details> <details> <summary>sass/dart-sass</summary> ### [`v1.58.0`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#​1580) [Compare Source](https://togithub.com/sass/dart-sass/compare/1.57.1...1.58.0) - Remove sourcemap comments from Sass sources. The generated sourcemap comment for the compiled CSS output remains unaffected. - Fix a bug in `@extend` logic where certain selectors with three or more combinators were incorrectly considered superselectors of similar selectors with fewer combinators, causing them to be incorrectly trimmed from the output. - Produce a better error message for a number with a leading `+` or `-`, a decimal point, but no digits. - Produce a better error message for a nested property whose name starts with `--`. - Fix a crash when a selector ends in an escaped backslash. - Add the relative length units from CSS Values 4 and CSS Contain 3 as known units to validate bad computation in `calc`. ##### Command Line Interface - The `--watch` flag will now track loads through calls to `meta.load-css()` as long as their URLs are literal strings without any interpolation. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/google/osv.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43My4zIiwidXBkYXRlZEluVmVyIjoiMzQuMTE0LjAifQ==-->
](https://renovatebot.com){kind=link}
|
Hello. I'm noticing that this work will remove HEAD elements such as CSP meta nonces (and others) when a Turbo Frame request is made with What I'm seeing is that the Turbo Frame request will render this layout It took a while to figure this out and find a workaround which is to ensure a full application layout with a proper HEAD section is rendered for these Turbo Frame requests, but that doesn't seem right, unless I'm missing something. I can try to put together a reproducible test app but wanted to gauge the temperature first and see if there is anything obvious that I"m missing :) Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #719
When turbo loads a page, the current behavior is to remove and replace all provisional head elements. This would include the title tag, meta tags, and link tags to icons, fonts and manifest.json. This can lead to additional http requests as demonstrated below:
Turbo-current.mp4
This PR merges the elements instead providing a cleaner page load experience and preventing these potential additional requests.
Turbo-Merge.mp4
Unit test note:
I was not able to get the test suite running and encountered this issue:
If this PR has potential, I could use some assistance getting things up and running.