Revert "Dispatch visit events on the initiator link or form (#695)" #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inclusion of the `initiator` in `VisitOptions` causes a JS crash in the Turbo iOS adapter. This is because Turbo iOS's implementation of `visitProposedToLocation` relies on being able to pass the entire options struct to native code. Initiator is an `Element`, which can't be passed in this way, resulting in a `DataCloneError` exception. There is some discussion on this [GitHub issue][]. We're reverting the change for the moment, until we have an implementation of it that works with all adapters. [GitHub issue]: #720 This reverts commit 8871817.
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 19, 2022
With the reverting of [hotwired#569][] (merged as [hotwired#723][]), the "Visit with network error" test coverage was missed in the diff. Prior to the revert, the test was listening for `turbo:fetch-request-error` events dispatched on the _link_ that was clicked. Since that's no longer the case, this commit changes the test to listen for `turbo:fetch-request-error` that bubble up to the document. [hotwired#569]: hotwired#569 [hotwired#723]: hotwired#723
|
I've opened #725 to resolve this PR's CI test failures. |
dhh
pushed a commit
that referenced
this pull request
Sep 19, 2022
With the reverting of [#569][] (merged as [#723][]), the "Visit with network error" test coverage was missed in the diff. Prior to the revert, the test was listening for `turbo:fetch-request-error` events dispatched on the _link_ that was clicked. Since that's no longer the case, this commit changes the test to listen for `turbo:fetch-request-error` that bubble up to the document. [#569]: #569 [#723]: #723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion of the
initiatorinVisitOptionscauses a JS crash in the Turbo iOS adapter.This is because Turbo iOS's implementation of
visitProposedToLocationrelies on being able to pass the entire options struct to native code. Initiator is anElement, which can't be passed in this way, resulting in aDataCloneErrorexception.There is some discussion on this GitHub issue. This PR reverts the change for the moment, until we have an implementation of it that works with all adapters.
This reverts commit 8871817.