Load data-turbo-method links within the correct turbo frame #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything else needed to move this forward ? I'm actually using a forked version of turbo with these changes in production and it's running fantastic. There are a few conflicts following recent development on |
spohlenz
force-pushed
the
method-link-inside-form
branch
from
83d403d to
aa2bff9
Compare
|
I've rebased and verified that the tests are still passing. |
|
For me this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of @davidgil's work in #341, and addresses the problem raised by @acetinick in #358.
In addition it also addresses some other concerns that had been raised:
data-turbo-frametargets on links withdata-turbo-methodset