Fix test to verify no network request on prefetched link click #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was supposed to assert that a network request was not made when clicking on a link that had been prefetched by hovering over it. However, the test was not actually making the click, just trying to hover over an already hovered link, so this wasn't really testing what it was supposed to.
afcapel
reviewed
May 13, 2024
| let requestMade = false | ||
| page.on("request", async (request) => (requestMade = true)) | ||
| await clickSelector({ page, selector }) | ||
| assertRequestNotMade(requestMade) |
There was a problem hiding this comment.
Can we add a callback to the assertRequestMade / assertRequestNotMade helpers so we can move the requestMade and event handler declaration to the helpers, so this looks like:
assertRequestNotMade(async () => {
await clickSelector({ page, selector })
})There was a problem hiding this comment.
Sorry, just got free right now to tackle this.
Good call, love the resulting abstraction. LMK if this is what you had in mind.
These functions are called to perform the action that should trigger the network request. This allows us to test different scenarios without repeating the same code. It also allows us to pass a callback that will be called with the request object when the request is made. This is useful for testing the request object itself.
|
Thanks @davidalejandroaguilar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test aimed to verify that no network request occurs when clicking a link that had already been prefetched by hovering. However, instead of performing a click, the test erroneously attempted to hover over the link again, which had already been hovered over. Therefore, it failed to test the intended behavior.
This PR makes sure that the test is correctly set up to prevent any regression in this functionality.