LinkPrefetchObserver: replace dataset with getAttribute
#1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, import the `StreamMessage` module to utilize the `contentType` instead of the hard-coded `"text/vnd.turbo-stream.html"` String. Next, replace occurrences of [HTMLElement.dataset][] with the `"data-"`-prefixed calls to [Element.getAttribute][] so that they are as `grep`-able as their counterparts elsewhere in the codebase. Finally, remove a `link` comparison conditional clause, since it's repeated verbatim several lines prior to it. [HTMLElement.dataset]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dataset [Element.getAttribute]: https://developer.mozilla.org/en-US/docs/Web/API/Element/getAttribute
seanpdoyle
force-pushed
the
link-prefetch-data-attributes
branch
from
1c8dc21 to
5c2d08c
Compare
|
Thanks @seanpdoyle ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, import the
StreamMessagemodule to utilize thecontentTypeinstead of the hard-coded
"text/vnd.turbo-stream.html"String.Next, replace occurrences of HTMLElement.dataset with the
"data-"-prefixed calls to Element.getAttribute so that they are asgrep-able as their counterparts elsewhere in the codebase.Finally, remove a
linkcomparison conditional clause, since it'srepeated verbatim several lines prior to it.