Do not dispatch multiple visit events on redirect visit #1044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#328 fixed an issue with the window's location in native adapters (hotwired/turbo-ios#30 & hotwired/turbo-android#128).
However, proposing a new visit re-runs the visit lifecycle again, duplicating events, and introduced issues such as #428, #526, #537 & #877.
This pull request reverts the visit proposal, and instead updates the location as part of
changeHistory()
. (This may not have been doable before #601.) It leads to a simplerfollowRedirect
method that now just updates the visit's location. As such, we no longer need the fix from #563.Fixes #877