Replace FormInterceptor with FormSubmitObserver

Unify `<form>` element submission event listening by replacing all
`FormInterceptor` call sites and `FormInterceptorDelegate` implementers,
replacing them with the `FormSubmitObserver` pattern.

src/core/frames/frame_controller.ts

@@ -2,23 +2,23 @@ import { FrameElement, FrameElementDelegate, FrameLoadingStyle } from "../../ele
 import { FetchMethod, FetchRequest, FetchRequestDelegate, FetchRequestHeaders } from "../../http/fetch_request"
 import { FetchResponse } from "../../http/fetch_response"
 import { AppearanceObserver, AppearanceObserverDelegate } from "../../observers/appearance_observer"
+import { FormSubmitObserver, FormSubmitObserverDelegate } from "../../observers/form_submit_observer"
 import { parseHTMLDocument } from "../../util"
 import { FormSubmission, FormSubmissionDelegate } from "../drive/form_submission"
 import { Snapshot } from "../snapshot"
 import { ViewDelegate } from "../view"
 import { expandURL, urlsAreEqual, Locatable } from "../url"
-import { FormInterceptor, FormInterceptorDelegate } from "./form_interceptor"
 import { FrameView } from "./frame_view"
 import { LinkInterceptor, LinkInterceptorDelegate } from "./link_interceptor"
 import { FrameRenderer } from "./frame_renderer"
 import { session } from "../index"
 
-export class FrameController implements AppearanceObserverDelegate, FetchRequestDelegate, FormInterceptorDelegate, FormSubmissionDelegate, FrameElementDelegate, LinkInterceptorDelegate, ViewDelegate<Snapshot<FrameElement>> {
+export class FrameController implements AppearanceObserverDelegate, FetchRequestDelegate, FormSubmitObserverDelegate, FormSubmissionDelegate, FrameElementDelegate, LinkInterceptorDelegate, ViewDelegate<Snapshot<FrameElement>> {
   readonly element: FrameElement
   readonly view: FrameView
   readonly appearanceObserver: AppearanceObserver
   readonly linkInterceptor: LinkInterceptor
-  readonly formInterceptor: FormInterceptor
+  readonly formSubmitObserver: FormSubmitObserver
   currentURL?: string | null
   formSubmission?: FormSubmission
   private resolveVisitPromise = () => {}
@@ -31,7 +31,7 @@ export class FrameController implements AppearanceObserverDelegate, FetchRequest
     this.view = new FrameView(this, this.element)
     this.appearanceObserver = new AppearanceObserver(this, this.element)
     this.linkInterceptor = new LinkInterceptor(this, this.element)
-    this.formInterceptor = new FormInterceptor(this, this.element)
+    this.formSubmitObserver = new FormSubmitObserver(this, this.element)
   }
 
   connect() {
@@ -42,7 +42,7 @@ export class FrameController implements AppearanceObserverDelegate, FetchRequest
         this.appearanceObserver.start()
       }
       this.linkInterceptor.start()
-      this.formInterceptor.start()
+      this.formSubmitObserver.start()
       this.sourceURLChanged()
     }
   }
@@ -52,7 +52,7 @@ export class FrameController implements AppearanceObserverDelegate, FetchRequest
       this.connected = false
       this.appearanceObserver.stop()
       this.linkInterceptor.stop()
-      this.formInterceptor.stop()
+      this.formSubmitObserver.stop()
     }
   }
 
@@ -140,11 +140,12 @@ export class FrameController implements AppearanceObserverDelegate, FetchRequest
 
   // Form interceptor delegate
 
-  shouldInterceptFormSubmission(element: HTMLFormElement, submitter?: Element) {
-    return this.shouldInterceptNavigation(element, submitter)
+  willSubmitForm(element: HTMLFormElement, submitter?: Element) {
+    return element.closest("turbo-frame") == this.element &&
+      this.shouldInterceptNavigation(element, submitter)
   }
 
-  formSubmissionIntercepted(element: HTMLFormElement, submitter?: HTMLElement) {
+  formSubmitted(element: HTMLFormElement, submitter?: HTMLElement) {
     if (this.formSubmission) {
       this.formSubmission.stop()
     }

src/core/frames/frame_redirector.ts

@@ -1,26 +1,26 @@
-import { FormInterceptor, FormInterceptorDelegate } from "./form_interceptor"
+import { FormSubmitObserver, FormSubmitObserverDelegate } from "../../observers/form_submit_observer"
 import { FrameElement } from "../../elements/frame_element"
 import { LinkInterceptor, LinkInterceptorDelegate } from "./link_interceptor"
 
-export class FrameRedirector implements LinkInterceptorDelegate, FormInterceptorDelegate {
+export class FrameRedirector implements LinkInterceptorDelegate, FormSubmitObserverDelegate {
   readonly element: Element
   readonly linkInterceptor: LinkInterceptor
-  readonly formInterceptor: FormInterceptor
+  readonly formSubmitObserver: FormSubmitObserver
 
   constructor(element: Element) {
     this.element = element
     this.linkInterceptor = new LinkInterceptor(this, element)
-    this.formInterceptor = new FormInterceptor(this, element)
+    this.formSubmitObserver = new FormSubmitObserver(this, element)
   }
 
   start() {
     this.linkInterceptor.start()
-    this.formInterceptor.start()
+    this.formSubmitObserver.start()
   }
 
   stop() {
     this.linkInterceptor.stop()
-    this.formInterceptor.stop()
+    this.formSubmitObserver.stop()
   }
 
   shouldInterceptLinkClick(element: Element, url: string) {
@@ -35,15 +35,16 @@ export class FrameRedirector implements LinkInterceptorDelegate, FormInterceptor
     }
   }
 
-  shouldInterceptFormSubmission(element: HTMLFormElement, submitter?: HTMLElement) {
-    return this.shouldRedirect(element, submitter)
+  willSubmitForm(element: HTMLFormElement, submitter?: HTMLElement) {
+    return element.closest("turbo-frame") == null &&
+      this.shouldRedirect(element, submitter)
   }
 
-  formSubmissionIntercepted(element: HTMLFormElement, submitter?: HTMLElement) {
+  formSubmitted(element: HTMLFormElement, submitter?: HTMLElement) {
     const frame = this.findFrameElement(element, submitter)
     if (frame) {
       frame.removeAttribute("reloadable")
-      frame.delegate.formSubmissionIntercepted(element, submitter)
+      frame.delegate.formSubmitted(element, submitter)
     }
   }
 

src/core/session.ts

@@ -30,7 +30,7 @@ export class Session implements FormSubmitObserverDelegate, HistoryDelegate, Lin
   readonly pageObserver = new PageObserver(this)
   readonly cacheObserver = new CacheObserver()
   readonly linkClickObserver = new LinkClickObserver(this)
-  readonly formSubmitObserver = new FormSubmitObserver(this)
+  readonly formSubmitObserver = new FormSubmitObserver(this, document)
   readonly scrollObserver = new ScrollObserver(this)
   readonly streamObserver = new StreamObserver(this)
 

src/elements/frame_element.ts

@@ -8,7 +8,7 @@ export interface FrameElementDelegate {
   loadingStyleChanged(): void
   sourceURLChanged(): void
   disabledChanged(): void
-  formSubmissionIntercepted(element: HTMLFormElement, submitter?: HTMLElement): void
+  formSubmitted(element: HTMLFormElement, submitter?: HTMLElement): void
   loadResponse(response: FetchResponse): void
   isLoading: boolean
 }

src/observers/form_submit_observer.ts

@@ -5,29 +5,31 @@ export interface FormSubmitObserverDelegate {
 
 export class FormSubmitObserver {
   readonly delegate: FormSubmitObserverDelegate
+  readonly eventTarget: EventTarget
   started = false
 
-  constructor(delegate: FormSubmitObserverDelegate) {
+  constructor(delegate: FormSubmitObserverDelegate, eventTarget: EventTarget) {
     this.delegate = delegate
+    this.eventTarget = eventTarget
   }
 
   start() {
     if (!this.started) {
-      addEventListener("submit", this.submitCaptured, true)
+      this.eventTarget.addEventListener("submit", this.submitCaptured, true)
       this.started = true
     }
   }
 
   stop() {
     if (this.started) {
-      removeEventListener("submit", this.submitCaptured, true)
+      this.eventTarget.removeEventListener("submit", this.submitCaptured, true)
       this.started = false
     }
   }
 
   submitCaptured = () => {
-    removeEventListener("submit", this.submitBubbled, false)
-    addEventListener("submit", this.submitBubbled, false)
+    this.eventTarget.removeEventListener("submit", this.submitBubbled, false)
+    this.eventTarget.addEventListener("submit", this.submitBubbled, false)
   }
 
   submitBubbled = <EventListener>((event: SubmitEvent) => {