Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Instaclick #157

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Document Instaclick #157

merged 5 commits into from
Feb 7, 2024

Conversation

afcapel
Copy link
Contributor

@afcapel afcapel commented Jan 25, 2024

davidalejandroaguilar
davidalejandroaguilar reviewed Jan 25, 2024
View reviewed changes
Copy link

@davidalejandroaguilar davidalejandroaguilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this, added some thoughts, but otherwise it's looking great!

_source/handbook/02_drive.md Outdated Show resolved Hide resolved
_source/handbook/02_drive.md Outdated Show resolved Hide resolved
_source/handbook/02_drive.md Outdated Show resolved Hide resolved
_source/handbook/02_drive.md Outdated Show resolved Hide resolved
@afcapel
Copy link
Contributor Author

afcapel commented Feb 6, 2024

@davidalejandroaguilar thanks, I've incorporated your suggestion in 0ef2331

@afcapel
Merge remote-tracking branch 'origin/main' into document-instaclick
13b75c7 
* origin/main:
  Document Morph events
  Add `[id]` to `<turbo-frame>` in Promotion example (#156)
  Update - Correct typo in 04_streams.md (#155)
  Update urls (#154)
  Fix a typo in the breaking out from a frame section
@davidalejandroaguilar
Copy link

Thanks @afcapel, don't want to be nit-picky but it still says "InstaClick" when the name of the inspiration library is "InstantClick".

Feel free to dismiss this comment if we're going with "InstaClick" or if this doesn't matter.

@afcapel
Copy link
Contributor Author

afcapel commented Feb 6, 2024

Thanks @afcapel, don't want to be nit-picky but it still says "InstaClick" when the name of the inspiration library is "InstantClick".

@davidalejandroaguilar do'h I just realized that 🤦

Fixed in e1eaa43

@afcapel afcapel merged commit 704ca23 into main Feb 7, 2024
@afcapel afcapel deleted the document-instaclick branch February 7, 2024 10:18
afcapel added a commit that referenced this pull request Feb 7, 2024
@afcapel
Merge remote-tracking branch 'origin/main' into document-view-transit…
e6fe03e 
…ions

* origin/main:
  Document Instaclick (#157)
  Document page refreshes with morphing (#160)
  Document Morph events
  Add `[id]` to `<turbo-frame>` in Promotion example (#156)
  Update - Correct typo in 04_streams.md (#155)
  Update urls (#154)
  Fix a typo in the breaking out from a frame section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidalejandroaguilar davidalejandroaguilar davidalejandroaguilar left review comments

@kevinmcconnell kevinmcconnell Awaiting requested review from kevinmcconnell

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afcapel @davidalejandroaguilar