Add attributes hash as optional arg to replace/update model tag builders #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarluq
force-pushed
the
allow-attributes-in-controller-tag-builders
branch
from
b01a078
to
5e4d48f
Compare
omarluq
changed the title
jorgemanrubia
requested changes
Aug 6, 2024
There was a problem hiding this comment.
@omarluq instead of allowing arbitrary attributes I'd rather add a dedicated method: key. Could you please change that?
Thanks for working on this.
@jorgemanrubia I will open a new PR that adds |
|
this can be closed cause #665 |
|
Sorry I merged this one but I inteded to merge this other one: #665. I reverted it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.