Alter Action Cable Element to be morph-compatible #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorgemanrubia @brunoprietog are either of you able to review these changes? |
seanpdoyle
force-pushed
the
issue-638
branch
6 times, most recently
from
2b4b903
to
e306940
Compare
|
This would be great! |
seanpdoyle
force-pushed
the
issue-638
branch
2 times, most recently
from
7b12849
to
84bab74
Compare
|
@seanpdoyle could you please solve the conflicts, I'll merge 🙏 |
seanpdoyle
force-pushed
the
issue-638
branch
from
84bab74
to
23ca7af
Compare
Closes [hotwired#638][] Recent changes to integrate with morphing have altered the mental model for some Turbo custom elements, including the `<turbo-cable-stream-source>` element. Custom Elements' `connectedCallback()` and `disconnectedCallback()` (along with Stimulus' `connect()` and `disconnect()`) improved upon invoking code immediately, or listening for `DOMContentLoaded` events. There are similar improvements to be made to integrate with morphing. First, [observe attribute changes][] by declaring their own `static observedAttributes` properties along with `attributeChangedCallback(name, oldValue, newValue)` callbacks. Those callbacks execute the same initialization code as their current `connectedCallback()` and `disconnectedCallback()` methods. That'll help resolve this issue. In addition to those changes, it's important to emphasize this pattern for consumer applications moving forward. JavaScript code (whether Stimulus controller or otherwise) should be implemented in a way that' resilient to both asynchronous connection and disconnection *as well as* asynchronous modification of attributes. [hotwired#638]: hotwired#638 [observe attribute changes]: https://developer.mozilla.org/en-US/docs/Web/API/Web_Components/Using_custom_elements#responding_to_attribute_changes
seanpdoyle
force-pushed
the
issue-638
branch
from
23ca7af
to
4e7fbdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #638
Recent changes to integrate with morphing have altered the mental model for some Turbo custom elements, including the
<turbo-cable-stream-source>element.Custom Elements'
connectedCallback()anddisconnectedCallback()(along with Stimulus'connect()anddisconnect()) improved upon invoking code immediately, or listening forDOMContentLoadedevents.There are similar improvements to be made to integrate with morphing. First, observe attribute changes by declaring their own
static observedAttributesproperties along withattributeChangedCallback(name, oldValue, newValue)callbacks. Those callbacks execute the same initialization code as their currentconnectedCallback()anddisconnectedCallback()methods.That'll help resolve this issue. In addition to those changes, it's important to emphasize this pattern for consumer applications moving forward. JavaScript code (whether Stimulus controller or otherwise) should be implemented in a way that' resilient to both asynchronous connection and disconnection as well as asynchronous modification of attributes.